Skip to content

Minigrid settings#4917

Merged
TomJaeger merged 4 commits intoExpressionEngine:7.devfrom
swierczek:minigrid-settings
Aug 6, 2025
Merged

Minigrid settings#4917
TomJaeger merged 4 commits intoExpressionEngine:7.devfrom
swierczek:minigrid-settings

Conversation

@swierczek
Copy link
Contributor

Fixed issue where if minigrid settings was missing grid_min_rows, it would calculate neededRows to NaN and would cause the initial "Add" button to not appear.

This also fixes a typo with 2 function names: Grig -> Grid

This avoids a NaN calculation if the setting isn't defined
@TomJaeger TomJaeger requested a review from Yulyaswan July 23, 2025 12:32
@TomJaeger TomJaeger added this to the 7.5.14 milestone Jul 23, 2025
@TomJaeger TomJaeger modified the milestones: 7.5.14, 7.5.15 Aug 4, 2025
@TomJaeger TomJaeger merged commit dab86f7 into ExpressionEngine:7.dev Aug 6, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants