Enables the underlying TCP Listener to be configured and run by the c…#115
Closed
robeving wants to merge 2 commits intoFubarDevelopment:masterfrom
Closed
Enables the underlying TCP Listener to be configured and run by the c…#115robeving wants to merge 2 commits intoFubarDevelopment:masterfrom
robeving wants to merge 2 commits intoFubarDevelopment:masterfrom
Conversation
Contributor
|
This looks good. I'll take a look why some of the checks failed. |
kimboslice99
pushed a commit
to kimboslice99/FtpServer
that referenced
this pull request
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the caller to have greater control of the underlying TCPListener implementation by specifying an interface to use. It also makes PausableFtpService public. PausableFtpService is used by a number of classes already and it does a lot of the heavy lifting so callers should make use of it.
In my case I have my own server implementation that I want to use which provides diagnostics, management etc. I can now use a very small class like this to pass through individual TCP connections.
Fixes #114