test: add Python 3.13 to noxfile_config.py files#13062
Merged
Conversation
holtskinner
approved these changes
Jan 15, 2025
ghost
reviewed
Jan 15, 2025
ghost
left a comment
There was a problem hiding this comment.
Hi @parthea, reviewers, and future viewers!
I'm Gemini, and I'm currently reviewing this pull request. In the meantime, here's a quick summary to help everyone get up to speed:
This pull request aims to add Python 3.13 to the list of Python versions considered in the noxfile_config.py files across various Google Cloud Platform sample projects. This ensures that tests are run against the latest Python version, maintaining compatibility and identifying potential issues early.
Here's a breakdown of the changes:
- Intent: Expand Python version testing to include Python 3.13.
- Changes: The
ignored_versionslist within theTEST_CONFIG_OVERRIDEdictionary (and in some casesTEST_CONFIG) in each of the affectednoxfile_config.pyfiles has been updated to include "3.13". This affects the following files:alloydb/notebooks/noxfile_config.py(line 17)appengine/flexible/django_cloudsql/noxfile_config.py(line 25)appengine/flexible/numpy/noxfile_config.py(line 26)appengine/flexible/scipy/noxfile_config.py(line 25)appengine/flexible_python37_and_earlier/analytics/noxfile_config.py(line 26)appengine/flexible_python37_and_earlier/datastore/noxfile_config.py(line 26)appengine/flexible_python37_and_earlier/disk/noxfile_config.py(line 26)appengine/flexible_python37_and_earlier/django_cloudsql/noxfile_config.py(line 26)appengine/flexible_python37_and_earlier/extending_runtime/noxfile_config.py(line 26)appengine/flexible_python37_and_earlier/hello_world/noxfile_config.py(line 26)appengine/flexible_python37_and_earlier/hello_world_django/noxfile_config.py(line 26)appengine/flexible_python37_and_earlier/metadata/noxfile_config.py(line 26)appengine/flexible_python37_and_earlier/multiple_services/noxfile_config.py(line 26)appengine/flexible_python37_and_earlier/numpy/noxfile_config.py(line 26)appengine/flexible_python37_and_earlier/pubsub/noxfile_config.py(line 26)appengine/flexible_python37_and_earlier/scipy/noxfile_config.py(line 26)appengine/flexible_python37_and_earlier/static_files/noxfile_config.py(line 26)appengine/flexible_python37_and_earlier/storage/noxfile_config.py(line 26)appengine/flexible_python37_and_earlier/tasks/noxfile_config.py(line 26)appengine/flexible_python37_and_earlier/twilio/noxfile_config.py(line 26)appengine/flexible_python37_and_earlier/websockets/noxfile_config.py(line 26)appengine/standard/noxfile-template.py(lines 40 and 85)appengine/standard_python3/bundled-services/blobstore/django/noxfile_config.py(line 25)appengine/standard_python3/bundled-services/blobstore/flask/noxfile_config.py(line 25)appengine/standard_python3/bundled-services/blobstore/wsgi/noxfile_config.py(line 25)appengine/standard_python3/bundled-services/deferred/django/noxfile_config.py(line 25)appengine/standard_python3/bundled-services/deferred/flask/noxfile_config.py(line 25)appengine/standard_python3/bundled-services/deferred/wsgi/noxfile_config.py(line 25)appengine/standard_python3/bundled-services/mail/django/noxfile_config.py(line 25)appengine/standard_python3/bundled-services/mail/flask/noxfile_config.py(line 25)appengine/standard_python3/bundled-services/mail/wsgi/noxfile_config.py(line 25)appengine/standard_python3/django/noxfile_config.py(line 25)automl/snippets/noxfile_config.py(line 25)cloud-media-livestream/keypublisher/noxfile_config.py(line 25)composer/airflow_1_samples/noxfile_config.py(line 35)contentwarehouse/snippets/noxfile_config.py(line 25)dataflow/custom-containers/miniconda/noxfile_config.py(line 28)dataflow/custom-containers/minimal/noxfile_config.py(line 28)dataflow/custom-containers/ubuntu/noxfile_config.py(line 28)dataflow/extensible-templates/noxfile_config.py(line 25)dataflow/flex-templates/pipeline_with_dependencies/noxfile_config.py(line 22)dataflow/flex-templates/streaming_beam/noxfile_config.py(line 28)dataflow/gemma-flex-template/noxfile_config.py(line 22)dataflow/gemma/noxfile_config.py(line 22)dataflow/gpu-examples/pytorch-minimal/noxfile_config.py(line 28)dataflow/gpu-examples/tensorflow-landsat-prime/noxfile_config.py(line 28)dataflow/gpu-examples/tensorflow-landsat/noxfile_config.py(line 28)dataflow/gpu-examples/tensorflow-minimal/noxfile_config.py(line 28)dataflow/run-inference/noxfile_config.py(line 26)dataflow/snippets/noxfile_config.py(line 25)datastore/cloud-ndb/noxfile_config.py(line 28)dialogflow-cx/noxfile_config.py(line 25)dialogflow/noxfile_config.py(line 28)dns/api/noxfile_config.py(line 28)endpoints/getting-started/noxfile_config.py(line 28)functions/ocr/app/noxfile_config.py(line 27)language/snippets/classify_text/noxfile_config.py(line 28)ml_engine/online_prediction/noxfile_config.py(line 25)noxfile-template.py(line 91)people-and-planet-ai/geospatial-classification/noxfile_config.py(line 26)people-and-planet-ai/image-classification/noxfile_config.py(line 26)people-and-planet-ai/land-cover-classification/noxfile_config.py(line 29)people-and-planet-ai/timeseries-classification/noxfile_config.py(line 28)people-and-planet-ai/weather-forecasting/tests/dataset_tests/noxfile_config.py(line 28)people-and-planet-ai/weather-forecasting/tests/overview_tests/noxfile_config.py(line 26)people-and-planet-ai/weather-forecasting/tests/predictions_tests/noxfile_config.py(line 26)people-and-planet-ai/weather-forecasting/tests/training_tests/noxfile_config.py(line 26)profiler/appengine/flexible/noxfile_config.py(line 26)profiler/appengine/standard_python37/noxfile_config.py(line 25)pubsub/streaming-analytics/noxfile_config.py(line 25)run/idp-sql/noxfile_config.py(line 26)service_extensions/callouts/add_header/noxfile_config.py(line 25)speech/microphone/noxfile_config.py(line 18)storagecontrol/noxfile_config.py(line 25)trace/trace-python-sample-opentelemetry/noxfile_config.py(line 28)translate/samples/snippets/noxfile_config.py(line 26)
- Activity: No activity noted beyond the initial commit.
Let me know if you have any questions!
Small change, big impact,
Testing's reach now expands,
3.13 embraced.
|
Gemini encountered an error creating the review. You can try again by commenting |
ShuoyuM
approved these changes
Jan 15, 2025
Contributor
|
This PR should also change the base Since this PR is hitting nearly every sample, and periodics are failing for the same samples, CI won't pass for this PR. |
Collaborator
Author
|
Fixed |
SandeepTuniki
approved these changes
Jan 16, 2025
Collaborator
Author
|
The failures in |
1 task
glasnt
pushed a commit
that referenced
this pull request
Jan 22, 2025
* test: add Python 3.13 to noxfile_config.py files * Ignore Python 3.12; Mark Python 3.13 presubmit as required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is similar to #10946
Fixes: #12728