[Asset] Add requirements.txt#1834
Merged
gguuss merged 19 commits intoGoogleCloudPlatform:masterfrom Nov 13, 2018
peter-zheng-g:master
Merged
[Asset] Add requirements.txt#1834gguuss merged 19 commits intoGoogleCloudPlatform:masterfrom peter-zheng-g:master
gguuss merged 19 commits intoGoogleCloudPlatform:masterfrom
peter-zheng-g:master
Conversation
Remove "All Rights Reserved.".
gguuss
suggested changes
Nov 13, 2018
Contributor
gguuss
left a comment
There was a problem hiding this comment.
A few things I missed in the initial review. Sorry for that, let's take another look tomorrow morning before my meetings.
gguuss
reviewed
Nov 13, 2018
Contributor
Author
|
Thanks! |
Contributor
|
Please update the branch. |
gguuss
suggested changes
Nov 13, 2018
gguuss
reviewed
Nov 13, 2018
| except Exception: | ||
| pass | ||
| except Exception as e: | ||
| print('Failed to delete bucket{}'.format(BUCKET)) |
Contributor
There was a problem hiding this comment.
Space between bucket and {}:
print('Failed to delete bucket: {}'.format(BUCKET))
gguuss
approved these changes
Nov 13, 2018
Contributor
gguuss
left a comment
There was a problem hiding this comment.
LGTM, consider cleaning up your formatting on the exception in the test.
arithmetic1728
pushed a commit
to googleapis/python-asset
that referenced
this pull request
Jul 31, 2020
…s-samples#1834) Adds asset quickstart
busunkim96
pushed a commit
to googleapis/python-asset
that referenced
this pull request
Aug 4, 2020
…s-samples#1834) Adds asset quickstart
engelke
pushed a commit
that referenced
this pull request
Nov 28, 2022
dandhlee
pushed a commit
that referenced
this pull request
Nov 29, 2022
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Oct 21, 2023
…s-samples#1834) Adds asset quickstart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.