IAM: added snippet for remove member#2165
IAM: added snippet for remove member#2165gguuss merged 6 commits intoGoogleCloudPlatform:masterfrom DSdatsme:master
Conversation
gguuss
left a comment
There was a problem hiding this comment.
LGTM, let me know if you want me to merge or if you want to change the member in your test first.
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
I went ahead and pushed a few fixes for the tests to your fork. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
iam/api-client/access_test.py
Outdated
| policy = access.set_policy(project, policy) | ||
| policy = access.modify_policy_remove_member(policy, gcp_role, member) | ||
| out, _ = capsys.readouterr() | ||
| assert 'etag' in out |
There was a problem hiding this comment.
I'm seeing this test failing in Python 2.
Example code for removing a member in IAM policy.