Add SubscriberClient.close() to examples#2959
Closed
pradn wants to merge 2 commits intoGoogleCloudPlatform:masterfrom
Closed
Add SubscriberClient.close() to examples#2959pradn wants to merge 2 commits intoGoogleCloudPlatform:masterfrom
pradn wants to merge 2 commits intoGoogleCloudPlatform:masterfrom
Conversation
anguillanneuf
approved these changes
Feb 22, 2020
busunkim96
approved these changes
Feb 22, 2020
Contributor
Author
|
The close() method was only recently added. Perhaps you're thinking of something else? |
Member
|
@pradn Is it not this one here? Ah, I see. I was thinking of this one: I think something is wrong with the code because tests are stuck. I can take a close look next week. |
| except: # noqa | ||
| streaming_pull_future.cancel() | ||
| # Wrap subscriber in a 'with' block to automatically call close() when done. | ||
| with subscriber: |
Member
There was a problem hiding this comment.
This should be with client.
anguillanneuf
requested changes
Feb 25, 2020
Member
anguillanneuf
left a comment
There was a problem hiding this comment.
The library version looks outdated in requirements.txt.
Member
|
@pradn This branch has conflicts that must be resolved. I'm closing your PR and will work on a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.