Skip to content

New display() function that uses repr #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
takluyver wants to merge 2 commits into from
Closed

New display() function that uses repr #7

takluyver wants to merge 2 commits into from

Conversation

@takluyver
Copy link
Member

@takluyver takluyver commented Apr 25, 2015

See #6

@takluyver takluyver mentioned this pull request Apr 25, 2015
Closed
takluyver added a commit to IRkernel/IRkernel that referenced this pull request Apr 25, 2015
@takluyver
Updates for display() API using repr
879b7f0 
Depends on IRkernel/IRdisplay#7
@takluyver takluyver mentioned this pull request Apr 25, 2015
Closed
@jankatins jankatins mentioned this pull request Apr 26, 2015
Closed
10 tasks
@flying-sheep flying-sheep mentioned this pull request Apr 26, 2015
Closed
@flying-sheep
Copy link
Member

flying-sheep commented Apr 26, 2015

could you please add this?

#' @importFrom repr mime2repr
#' @importFrom repr repr_text

either at the top of the file like

#' @importFrom repr mime2repr
#' @importFrom repr repr_text
NULL

base_display <- ...

or to the doc comments of display.

generally i never touch NAMESPACE and always let roxygen2 do the job.

takluyver
takluyver reviewed Apr 26, 2015
View reviewed changes
R/display.R
Copy link
Member Author

@takluyver takluyver Apr 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flying-sheep you mean like this? Does it strictly need to be on two lines? I think I've seen it like this elsewhere, but maybe not. I did use roxygen.

Copy link
Member

@flying-sheep flying-sheep Apr 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like this, and one line is indeed better ☺️

@takluyver
Copy link
Member Author

takluyver commented Apr 26, 2015

Excellent. This one needs a manual merge now - anything else you want to review, or shall I go ahead and merge it?

@flying-sheep
Copy link
Member

flying-sheep commented Apr 26, 2015

Merged, but git didn’t detect it

@takluyver
Copy link
Member Author

takluyver commented Apr 26, 2015

Thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@takluyver @flying-sheep