Catch failures from repr and display the error #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in #97, now that handle_value and handle_graphics can call third-party code via repr, we should catch failures in those so they don't crash the kernel.
Member
|
good idea. should we do that or show a warning and return |
Contributor
|
IMO:
No sure what should happen, if all non-text/plain repr_* error: IMO the plain text one should be replaced by the error messages to send this to the users so that their is some info there. But if we per default send pdf and that would be the only one which is send back because all other image types error, then the notebook will only display the text plain one which will not have the error message :-( |
Member
Author
|
In IPython, we switched from showing a warning for repr failures to just treating it as an error, so that's what I'm following here. It's easier to debug an error than something showing up not as you expect. |
Contributor
|
@takluyver ok, then LGTM |
takluyver
added a commit
that referenced
this pull request
Apr 26, 2015
Catch failures from repr and display the error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #97, now that handle_value and handle_graphics can call third-party code via repr, we should catch failures in those so they don't crash the kernel.