Check capabilities before generating plot reprs#3
Merged
flying-sheep merged 2 commits intoIRkernel:masterfrom Apr 26, 2015
Merged
Check capabilities before generating plot reprs#3flying-sheep merged 2 commits intoIRkernel:masterfrom
flying-sheep merged 2 commits intoIRkernel:masterfrom
Conversation
Closes IRkernel/IRkernel#96, hopefully.
R/recordedplot.r
Outdated
Member
Author
There was a problem hiding this comment.
I assume this being FALSE would mean we couldn't generate a png - likewise for jpeg below.
Member
There was a problem hiding this comment.
yeah, although i can’t imagine what setup would result in this being false… embedded R? 😆
yeah, you can configure it to build without but i doubt anyone using repr would ever do this. still, why not put the check in?
Member
|
won’t work. try |
Member
Author
|
Thanks, fixed. We should work on some automated tests for this, but that can be after the release. I'll file a separate issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes IRkernel/IRkernel#96, hopefully.