Fix race condition in ConfigInvalidation.setup() with Promise-based init#13
Merged
shuv1337 merged 3 commits intomerge-config-reloadfrom Nov 13, 2025
Merged
Fix race condition in ConfigInvalidation.setup() with Promise-based init#13shuv1337 merged 3 commits intomerge-config-reloadfrom
shuv1337 merged 3 commits intomerge-config-reloadfrom
Conversation
Closed
…pattern Co-authored-by: kcrommett <523952+kcrommett@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add changes to address feedback on merge config reload
Fix race condition in ConfigInvalidation.setup() with Promise-based init
Nov 13, 2025
shuv1337
reviewed
Nov 13, 2025
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ConfigInvalidation.setup()function used a module-level boolean flag to prevent duplicate subscriptions, creating a race condition when called concurrently—multiple calls could pass the check before any set the flag.Changes:
initializedboolean withsetupPromise: Promise<void> | undefinedsetup()async, returning the stored Promise on subsequent callsConfigInvalidation.setup()inInstanceBootstrap()Before:
After:
Concurrent calls now await the same initialization Promise, ensuring exactly-once setup.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.