create a single shared object libscipy_openblas64_.so or libscipy_openblas.so#128
Merged
mattip merged 10 commits intoMacPython:mainfrom Jan 25, 2024
Merged
create a single shared object libscipy_openblas64_.so or libscipy_openblas.so#128mattip merged 10 commits intoMacPython:mainfrom
mattip merged 10 commits intoMacPython:mainfrom
Conversation
580b9c8 to
83c40b6
Compare
Collaborator
Author
|
There are some downstream projects using the tarball. here is a github search. This PR changes the shared objects in the tarball, I wonder if it will break their build. I asked on on the jdtuc/fdasrsf_python project. |
Collaborator
|
They all have copied the numpy/scipy script which pins to an exact hash, so I wouldn't worry about it. This repo is "use at your own risk" anyway. |
a013721 to
cc2c71c
Compare
cc2c71c to
8bff0b2
Compare
33dc2f8 to
8cbcf24
Compare
8cbcf24 to
2cf9674
Compare
Collaborator
Author
|
This works locally, even with the older tarballs. But it requires one change from numpy/numpy#25505: this fix for when scipy-openblas is detected by meson. So in order not to override the current tarball, which is used by numpy builds, I will bump the OpenBLAS version, which is overdue anyway. |
This was referenced Jan 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to numpy/numpy#25505
Instead of building a set of shared objects and creating symlinks to them, create only a single shared object. Use a patch to OpenBLAS.