Skip to content

[mpc] support for reference project union type#1322

Closed
gsino wants to merge 5 commits intoMessagePack-CSharp:masterfrom
gsino:fix_mpc_ignore_union_derived_type_defined_in_out_side_target
Closed

[mpc] support for reference project union type#1322
gsino wants to merge 5 commits intoMessagePack-CSharp:masterfrom
gsino:fix_mpc_ignore_union_derived_type_defined_in_out_side_target

Conversation

@gsino
Copy link

@gsino gsino commented Sep 7, 2021

Relates

#994
#1192

Overview

The two projects exists.

  • MyApp.Models.csproj
  • MyApp.Referenced.csproj that referenced by MyApp.Models.csproj

At this time, mpc will generate IUnionObjectFormatter, UnionDerived1Formatter and UnionDerived2Formatter.

in MyApp.Unity.csproj
[MessagePackObject]
public class MyObject
{
  [Key(0)]
  public IUnionObject Value { get; set; }
}
in MyApp.Referenced.csproj
[Union(0, typeof(UnionDerived1))]
[Union(1, typeof(UnionDerived2))]
public interface IUnionObject
{
  string Name { get; }
}

[MessagePackObject]
public class UnionDerived1 : IUnionObject
{
  [Key(0)]
  public int Id { get; set; }
  [Key(1)]
  public string Name { get; set; }
}

[MessagePackObject]
public class UnionDerived2 : IUnionObject
{
  [Key(0)]
  public string Name { get; set; }
}

goichi.shinohara added 4 commits September 7, 2021 18:54
Test for CollectUnion
dfa8d88 
- Union_Defined_In_TargetProject is currentry success
- Union_Defined_In_ReferencedProject is currentry failed
collect union derived types. for defined outside the target project.
0829fb3
refactor CollectGenericUnion method
ad70b8c 
Match the writing style to CollectUnion method
add license display for SA1633 error
af55a42
@gsino
Copy link
Author

gsino commented Nov 17, 2021

Hello.
Is there anything I need to do to continue this pull request?

@pCYSl5EDgo
Copy link
Contributor

pCYSl5EDgo commented Dec 9, 2021

It is necessary to pass the CI.

empty
44c1f3b 
Empty commit to check CI again
@gsino
Copy link
Author

gsino commented Dec 10, 2021

I ran the CI check again and it passed.
I can't confirm the details, but I think the last failure was a problem on the CI side.

@pCYSl5EDgo
Copy link
Contributor

pCYSl5EDgo commented Dec 11, 2021

Yes, CI has a buggy test.
Then we should wait AArnott for his review...

@gsino
Copy link
Author

gsino commented Dec 12, 2021

I got it.
Thank you!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2022

This pull request is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot closed this Mar 19, 2022
@gsino
Copy link
Author

gsino commented Mar 23, 2022

@neuecc
Can you confirm this Pull Request?

@neuecc neuecc reopened this Mar 29, 2022
@github-actions github-actions bot closed this Apr 4, 2022
@gsino gsino mentioned this pull request Jun 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

no-pr-activity source generation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gsino @pCYSl5EDgo @AArnott @neuecc

Comments