Improved UnityShims for better code sharing#1585
Merged
AArnott merged 2 commits intoMessagePack-CSharp:developfrom Jan 25, 2024
Merged
Improved UnityShims for better code sharing#1585AArnott merged 2 commits intoMessagePack-CSharp:developfrom
AArnott merged 2 commits intoMessagePack-CSharp:developfrom
Conversation
Collaborator
|
Thanks. It looks good, but I am not familiar with unity so I'm going to ask @neuecc to review. |
Collaborator
|
@neuecc ping on this. |
neuecc
approved these changes
Jan 24, 2024
Member
neuecc
left a comment
There was a problem hiding this comment.
sorry for delayed response.
It seems good.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Dec 2, 2025
This was referenced Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes it is necessary to share code between client and server, including Unity types like Vector2, Vector3 etc...
For better code sharing it is worth to have Unity-like properties and methods in UnityShims.