Skip to content

Switch from MSBuild properties to an AdditionalFiles json file#1667

Merged
AArnott merged 2 commits intodevelopfrom
fix1650
Aug 15, 2023
Merged

Switch from MSBuild properties to an AdditionalFiles json file#1667
AArnott merged 2 commits intodevelopfrom
fix1650

Conversation

@AArnott
Copy link
Collaborator

@AArnott AArnott commented Aug 13, 2023 •
edited
Loading

This allows unity (which has no msbuild properties) to configure the source generator via a JSON file passed to the compiler via AdditionalFiles.

Closes #1650

@AArnott AArnott added this to the v2.6 milestone Aug 13, 2023
@AArnott AArnott requested a review from neuecc August 13, 2023 03:06
This was referenced Aug 13, 2023
Closed
Open
@AArnott AArnott linked an issue Aug 13, 2023 that may be closed by this pull request
Provides SourceGenerator option from AdditionalFiles #1650
Closed
neuecc
neuecc approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@neuecc neuecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's wonderful!

Would the URL for the example schema in the ReadMe be
https://raw.githubusercontent.com/MessagePack-CSharp/MessagePack-CSharp/master/MessagePackAnalyzer.schema.json ?
Also, I think it's fine that the schema.json serves as the document, but it might be nice to have a link to it.

@AArnott
Copy link
Collaborator Author

AArnott commented Aug 14, 2023

Would the URL for the example schema in the ReadMe be
https://raw.githubusercontent.com/MessagePack-CSharp/MessagePack-CSharp/master/MessagePackAnalyzer.schema.json ?

Yes, I should have used MessagePack-CSharp as the account name. I'll fix that.
As for master instead of develop, that would delay its actual correctness to when develop finally merges into master (could be months away). So at least for now I think develop is better so folks can follow the README and get a working schema.

Also, I think it's fine that the schema.json serves as the document, but it might be nice to have a link to it.

I don't understand. Can you explain more about what you mean?

@neuecc
Copy link
Member

neuecc commented Aug 15, 2023

So at least for now I think develop is better so folks can follow the README and get a working schema.

OK!

Can you explain more about what you mean?

For example

The above example mostly sets defaults. You can discover all the available settings in MessagePackAnalyzer.schema.json, their defaults and meanings in a JSON editor that supports JSON schema.

@AArnott
Switch from MSBuild properties to an AdditionalFiles json file
ce0c7ca 
This allows unity (which has no msbuild properties) to configure the source generator.

Closes #1650
@AArnott AArnott enabled auto-merge August 15, 2023 12:54
@AArnott AArnott merged commit 3b8428e into develop Aug 15, 2023
@AArnott AArnott deleted the fix1650 branch August 15, 2023 13:08
@dependabot dependabot bot mentioned this pull request Jul 21, 2025
Closed
This was referenced Aug 4, 2025
Open
Open
Open
@dependabot dependabot bot mentioned this pull request Sep 19, 2025
Closed
This was referenced Nov 3, 2025
Merged
Open
Open
@dependabot dependabot bot mentioned this pull request Nov 10, 2025
Closed
This was referenced Dec 2, 2025
Closed
Open
Closed
Merged
This was referenced Jan 28, 2026
Closed
Open
@dependabot dependabot bot mentioned this pull request Feb 11, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neuecc neuecc neuecc approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

v3.0

Development

Successfully merging this pull request may close these issues.

Provides SourceGenerator option from AdditionalFiles

2 participants

@AArnott @neuecc