Fix simplified name for ValueTuple<T>#2033
Merged
AArnott merged 2 commits intoMessagePack-CSharp:developfrom Oct 23, 2024
Merged
Fix simplified name for ValueTuple<T>#2033AArnott merged 2 commits intoMessagePack-CSharp:developfrom
AArnott merged 2 commits intoMessagePack-CSharp:developfrom
Conversation
AArnott
approved these changes
Oct 23, 2024
Collaborator
AArnott
left a comment
There was a problem hiding this comment.
Thank you for this. Looks like I should spin another RC right away to fix this regression.
src/MessagePack.SourceGenerator/CodeAnalysis/QualifiedNamedTypeName.cs
Outdated
Show resolved
Hide resolved
This was referenced Dec 2, 2025
This was referenced Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix two issues:
ValueTuple<int>results invalid generated code:(int)QualifiedNamedTypeName.GetQualifiedName: float, double, decimal, bool, object