Skip to content

allow DynamicGenericResolver to StandardResolver in DynamicAssembly.AvoidDynamicCode#2105

Merged
neuecc merged 1 commit intomasterfrom
allow-dynamicgeneric
Dec 25, 2024
Merged

allow DynamicGenericResolver to StandardResolver in DynamicAssembly.AvoidDynamicCode#2105
neuecc merged 1 commit intomasterfrom
allow-dynamicgeneric

Conversation

@neuecc
Copy link
Member

@neuecc neuecc commented Dec 23, 2024

With the current Unity's IL2CPP Full Generic Sharing, MakeGenericType works in many cases.
Therefore, it can likely be enabled even with AvoidDynamicCode.
https://unity.com/blog/engine-platform/il2cpp-full-generic-sharing-in-unity-2022-1-beta

Regarding NativeAOT, we should fundamentally reconsider the strategy.
In any case, since this Resolver becomes the endpoint when AvoidDynamicCode is used, enabling it wouldn't make a difference (either way it will throw an exception - whether it's because the Formatter wasn't found or because of an invalid MakeGenericType call).

@neuecc neuecc merged commit bfce469 into master Dec 25, 2024
3 checks passed
@neuecc neuecc deleted the allow-dynamicgeneric branch December 25, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant