Conversation
AArnott
approved these changes
Feb 3, 2025
Collaborator
probably a bad call on my part. Feel free to make it mandatory.
I declared that type as it was the only way I could sanely track the many different paths a type can be found at. Also, the C# compiler creates tons of objects during compilation so it didn't strike me as a bad idea. But if you know a better way, that's great. |
Member
Author
|
Well, regarding the Source Generator, if we're going to continue maintaining it, it seems like I'll need to rebuild it from scratch. |
1 task
This was referenced Dec 2, 2025
This was referenced Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2149
SymbolStartActionofMsgPack00xMessagePackAnalyzercallsnew QualifiedNamedTypeName().The constructor of
QualifiedNamedTypeNamecan surprisingly cause Stackoverflow.The problem was fixed by setting recursionGuard.
I don't know why recursionGuard is made optional.
There are already several bug reports about this, and it seems to be dangerous code.
Also, generating a
QualifiedNamedTypeNamefor every symbol seems like a high cost.