AccessModifier was added to generated code.#2185
Merged
AArnott merged 1 commit intoMessagePack-CSharp:masterfrom Jun 6, 2025
Merged
AccessModifier was added to generated code.#2185AArnott merged 1 commit intoMessagePack-CSharp:masterfrom
AArnott merged 1 commit intoMessagePack-CSharp:masterfrom
Conversation
Contributor
Author
|
@dotnet-policy-service agree |
Contributor
Author
|
I've created a repro project for this issue. Here's the screenshot: |
AArnott
approved these changes
Jun 6, 2025
Collaborator
AArnott
left a comment
There was a problem hiding this comment.
Sure. This seems reasonable.
Member
|
@AArnott |
Collaborator
|
Yes, I think so. |
1 task
This was referenced Jul 21, 2025
This was referenced Aug 4, 2025
This was referenced Aug 18, 2025
This was referenced Dec 2, 2025
This was referenced Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I added an access modifier to QualifiedNamedTypeName to ensure it's generated for the owner class in cases where private fields need to be serialized. I also fixed the tests that were broken by this change.
In our project, we have a case where only Rider shows the following error:
Inconsistent accessibility: parameter type 'Shared.Common.User.Inventory.Data.Items.InventoryItem' is less accessible than method 'Shared.Meta.LootChests.IReadLootChests.CanOpen'
However, the code compiles and works correctly, so I assume this is a Rider-specific issue.
That said, I believe we can fix it by ensuring the generated code for InventoryItem includes an access modifier.
So, if you don't have any major concerns with this change, it would be great to get it merged.