Skip to content

Comments

Fallback to path for environmentTypeComparer#16893

Merged
karthiknadig merged 3 commits intomicrosoft:mainfrom
cdce8p:fix-sort-envs
Aug 10, 2021
Merged

Fallback to path for environmentTypeComparer#16893
karthiknadig merged 3 commits intomicrosoft:mainfrom
cdce8p:fix-sort-envs

Conversation

@cdce8p
Copy link

@cdce8p cdce8p commented Aug 7, 2021

I noticed that local environments weren't sorted correctly with pythonSortEnvs. Upon further investigation I found the issue was that PythonEnvironment only contained the path variable and not envPath. Thus the check failed to identify local environments correctly.

This PR would fix the issue. It is however primarily meant to help identify and narrow down the issue.

Steps to reproduce it:

  1. Open a folder or workspace in VS Code
  2. Create a virtual env with python -m venv venv
  3. Run Python: Select Interpreter command

--
macOS Catalina (10.15.7)
VS Code: 1.59.0

--
Current
Screen Shot 2021-08-08 at 00 28 23

With PR
Screen Shot 2021-08-08 at 00 27 18

Debug output
Screen Shot 2021-08-08 at 00 18 17

--
Python extension log output

User belongs to experiment group 'pythonSortEnvs'
User belongs to experiment group 'pythonaa'
User belongs to experiment group 'pythonSendEntireLineToREPL'
User belongs to experiment group 'pythonNotDisplayLinterPrompt'
User belongs to experiment group 'pythonDiscoveryModuleWithoutWatcher'
User belongs to experiment group 'pythonTensorboardExperiment'
User belongs to experiment group 'PythonPyTorchProfiler'
Python interpreter path: ./venv-310/bin/python
> pyenv root
> conda --version
> python3.7 -c "import sys;print(sys.executable)"
> python3.6 -c "import sys;print(sys.executable)"
> python3 -c "import sys;print(sys.executable)"
> python2 -c "import sys;print(sys.executable)"
> python -c "import sys;print(sys.executable)"
> ~/Develop/test-files/venv-310/bin/python -c "import sys;print(sys.executable)"
> conda info --json
Starting Pylance language server.
> conda --version

karthiknadig
karthiknadig approved these changes Aug 9, 2021
View reviewed changes
Copy link
Member

@karthiknadig karthiknadig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. This looks pretty good, also thanks for adding test for the change.

@karthiknadig karthiknadig requested a review from kimadeline August 9, 2021 03:21
@cdce8p @karthiknadig
Update news/2 Fixes/16893.md
39439e2 
Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
@karthiknadig karthiknadig merged commit a477bed into microsoft:main Aug 10, 2021
@cdce8p cdce8p deleted the fix-sort-envs branch August 10, 2021 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

+2 more reviewers

@karrtikr karrtikr karrtikr approved these changes

@kimadeline kimadeline kimadeline approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@karthiknadig karthiknadig

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cdce8p @karthiknadig @karrtikr @kimadeline