Add recognition for Dispose{} named function block#186
Closed
vexx32 wants to merge 1 commit intoPowerShell:masterfrom
Closed
Add recognition for Dispose{} named function block#186vexx32 wants to merge 1 commit intoPowerShell:masterfrom
vexx32 wants to merge 1 commit intoPowerShell:masterfrom
Conversation
Add dispose{} named block keyword to language files.
Yay, editor highlighting!
13 tasks
msftrncs
reviewed
Oct 13, 2019
Contributor
msftrncs
left a comment
There was a problem hiding this comment.
LGTM, this is all it takes at this time.
TylerLeonhardt
approved these changes
Oct 14, 2019
Member
TylerLeonhardt
left a comment
There was a problem hiding this comment.
LGTM awaiting merge in PowerShell repo
Member
|
Thanks for this! Closing as the alternative |
Member
|
Replaced by #208 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds dispose{} named block keyword to language files. Yay, editor highlighting! 🎉
Reference PowerShell/PowerShell#9900 for indication on when the feature will become available. From current team decisions it appears it will likely be merged post-v7 and generally available the following release.
This is all the references to named blocks I could find, and I updated an example or two while I was at it. If I missed anything, please let me know.
/cc @TylerLeonhardt