Change module root find function in CompatibilityRule#1196
Merged
bergmeister merged 3 commits intoPowerShell:developmentfrom Mar 28, 2019
Merged
Change module root find function in CompatibilityRule#1196bergmeister merged 3 commits intoPowerShell:developmentfrom
bergmeister merged 3 commits intoPowerShell:developmentfrom
Conversation
added 2 commits
March 26, 2019 09:40
JamesWTruher
approved these changes
Mar 26, 2019
bergmeister
approved these changes
Mar 27, 2019
Contributor
Author
|
Will let someone else merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
After @bergmeister's comments in @JamesWTruher's PR, I've made some small changes to the function that finds the PSScriptAnalyzer module root, the main one being that it will explicitly throw a
FileNotFoundExceptionwhen it gives up.PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.