update signing file for versioned location of module#1253
Merged
JamesWTruher merged 1 commit intoPowerShell:developmentfrom Jun 6, 2019
Merged
update signing file for versioned location of module#1253JamesWTruher merged 1 commit intoPowerShell:developmentfrom
JamesWTruher merged 1 commit intoPowerShell:developmentfrom
Conversation
bergmeister
reviewed
Jun 6, 2019
Collaborator
bergmeister
left a comment
There was a problem hiding this comment.
It's up to you but I suggest to do XML editing the file at runtime to put the version number into it, even just putting a placeholder and doing a simple string replace would do the job as well IMHO whilst keeping it simple
Contributor
Author
|
@bergmeister Agreed - when we move to VSTS CI I'm planning on a bit of a rewrite to generate more of this. For 1.18.1 I'll just do it manually, especially as the release is imminent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
These are the changes to build and sign script analyzer in VSTS.
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.