Compatibility tests: Use correct test cases object and remove invalid test case#1440
Merged
bergmeister merged 1 commit intomasterfrom Apr 16, 2020
Merged
Compatibility tests: Use correct test cases object and remove invalid test case#1440bergmeister merged 1 commit intomasterfrom
bergmeister merged 1 commit intomasterfrom
Conversation
… invalid test case
Contributor
I think that's worth doing. That class exists to allow JSON serialisation of versions across PowerShell versions, so it's not really necessary in the tests. Thanks for fixing this @bergmeister! |
rjmholt
approved these changes
Apr 14, 2020
Collaborator
Author
|
OK, I will merge this and open a 2nd PR later to add the capability of parsing a single character version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The
$genericVerCasestest case object was not being used due to what seems to have been a copy-paste error.One test case actually did not work because having a version string with not dot would throw here
I could add the following negative test for it but was wondering why we cannot make it accept single character versions?
In the case of PowerShell Core we wouldn't even need our own implementation and just use
System.Management.Automation.SemanticVersion, which can actually parse versions without a dot.PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.