Move common test code into AppVeyor module#961
Merged
JamesWTruher merged 6 commits intoPowerShell:developmentfrom Apr 9, 2018
Merged
Move common test code into AppVeyor module#961JamesWTruher merged 6 commits intoPowerShell:developmentfrom
JamesWTruher merged 6 commits intoPowerShell:developmentfrom
Conversation
…nalyzer into AppVeyorRefactor
7 tasks
…cal scope when being executed inside a module
…erence in module again
JamesWTruher
approved these changes
Apr 9, 2018
Contributor
JamesWTruher
left a comment
There was a problem hiding this comment.
this is certainly tidier!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Move test code into module function. To make this working, I had to fix some tests due to bugs in PowerShell. I left remarks about that in the already open issue PowerShell/PowerShell#6378
Replacing the
Copy-Itemstep with setting environment variables needs to be part of a different PR as it is currently not possible due to the way how the library usage tests work and therefore would require more refactoring.PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets. Please mark anything not applicable to this PRNA.NAUser facing documentation neededNAMake sure you've added a new test if existing tests do not effectively test the code changedWIP:to the beginning of the title and remove the prefix when the PR is ready