Support passing PSPath to native commands#12386
Merged
anmenaga merged 13 commits intoPowerShell:masterfrom Apr 27, 2020
Merged
Conversation
PoshChan
reviewed
Apr 20, 2020
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
PoshChan
reviewed
Apr 20, 2020
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
PoshChan
reviewed
Apr 20, 2020
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
PoshChan
reviewed
Apr 20, 2020
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
PoshChan
reviewed
Apr 20, 2020
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
iSazonov
reviewed
Apr 20, 2020
src/System.Management.Automation/engine/NativeCommandParameterBinder.cs
Outdated
Show resolved
Hide resolved
change string comparison to use string static methods
iSazonov
reviewed
Apr 21, 2020
src/System.Management.Automation/engine/NativeCommandParameterBinder.cs
Outdated
Show resolved
Hide resolved
…Binder.cs Co-Authored-By: Ilya <darpa@yandex.ru>
rjmholt
reviewed
Apr 21, 2020
src/System.Management.Automation/engine/NativeCommandParameterBinder.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/NativeCommandParameterBinder.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/NativeCommandParameterBinder.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/NativeCommandParameterBinder.cs
Outdated
Show resolved
Hide resolved
iSazonov
reviewed
Apr 22, 2020
src/System.Management.Automation/engine/NativeCommandParameterBinder.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/NativeCommandParameterBinder.cs
Outdated
Show resolved
Hide resolved
PoshChan
reviewed
Apr 22, 2020
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
Member
Author
|
@PoshChan retry macos |
Collaborator
|
@SteveL-MSFT, successfully started retry of |
PoshChan
reviewed
Apr 22, 2020
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
Member
Author
|
@PoshChan retry windows |
Collaborator
|
@SteveL-MSFT, successfully started retry of |
PoshChan
reviewed
Apr 22, 2020
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
anmenaga
reviewed
Apr 23, 2020
test/powershell/Language/Scripting/NativeExecution/NativeCommandArguments.Tests.ps1
Outdated
Show resolved
Hide resolved
…case for relative pspath, add test case for complex psdrive name
c85c7ed to
cf70fcc
Compare
PoshChan
reviewed
Apr 24, 2020
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
PoshChan
reviewed
Apr 24, 2020
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
PoshChan
reviewed
Apr 24, 2020
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
PoshChan
reviewed
Apr 25, 2020
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
…bing API returns z:\ for just z: which is not correct
PoshChan
reviewed
Apr 25, 2020
src/System.Management.Automation/engine/ExperimentalFeature/ExperimentalFeature.cs
Show resolved
Hide resolved
Member
Author
|
@PoshChan please retry windows |
Collaborator
|
@SteveL-MSFT, successfully started retry of |
11 tasks
|
Added doc issue: MicrosoftDocs/PowerShell-Docs#5848 |
anmenaga
approved these changes
Apr 27, 2020
|
🎉 Handy links: |
This was referenced May 19, 2020
This was referenced Sep 15, 2020
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Add a new
PSNativePSPathResolutionExperimental Feature where if a PSDrive is passed to a native command and uses the FileSystem provider, then the resolved file path is passed to the native command. This means something like:code temp:/test.txtnow works as expected. Also, on Windows, if the path starts with
~, then that will get resolved before passing to a native command. In both cases, the path is normalized to the directory separators for the relevant operating system. Note:PR Context
Fix #10675
Fix #11386
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.