@xtqqczze Please resolve merge conflicts and rebase.

@iSazonov We can reuse this PR for src\Microsoft.Management.Automation changes?

The PR is still huge.

@iSazonov ComInterop is frozen, but the code is not structured in separate project from System.Management.Automation, so we cannot currently disable analyzers for only ComInterop :(

D:\a\1\s\src\System.Management.Automation\engine\ComInterop\ExcepInfo.cs(18,23): error IDE0044: Make field readonly [D:\a\1\s\src\System.Management.Automation\System.Management.Automation.csproj]
D:\a\1\s\src\System.Management.Automation\engine\ComInterop\ExcepInfo.cs(19,23): error IDE0044: Make field readonly [D:\a\1\s\src\System.Management.Automation\System.Management.Automation.csproj]
D:\a\1\s\src\System.Management.Automation\engine\ComInterop\ExcepInfo.cs(23,21): error IDE0044: Make field readonly [D:\a\1\s\src\System.Management.Automation\System.Management.Automation.csproj]
D:\a\1\s\src\System.Management.Automation\engine\ComInterop\ExcepInfo.cs(24,24): error IDE0044: Make field readonly [D:\a\1\s\src\System.Management.Automation\System.Management.Automation.csproj]
D:\a\1\s\src\System.Management.Automation\engine\ComInterop\ExcepInfo.cs(25,24): error IDE0044: Make field readonly [D:\a\1\s\src\System.Management.Automation\System.Management.Automation.csproj]
D:\a\1\s\src\System.Management.Automation\engine\ComInterop\ExcepInfo.cs(26,21): error IDE0044: Make field readonly [D:\a\1\s\src\System.Management.Automation\System.Management.Automation.csproj]
D:\a\1\s\src\System.Management.Automation\engine\ComInterop\ComInvokeBinder.cs(26,37): error IDE0044: Make field readonly [D:\a\1\s\src\System.Management.Automation\System.Management.Automation.csproj]

@xtqqczze Please look the code in .Net Runtime repository. Perhaps they already fixed the issues. If no we could suppress the warnings on file level:

[ExcepInfo.cs]
dotnet_diagnostic.IDE0044.severity = none

(For generated code https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/configuration-options#exclude-generated-code)

/home/vsts/work/1/s/src/System.Management.Automation/engine/interpreter/InstructionList.cs(99,49): error CS0649: Field 'InstructionList._debugCookies' is never assigned to, and will always have its default value null [/home/vsts/work/1/s/src/System.Management.Automation/System.Management.Automation.csproj]

@xtqqczze Please look the code in .Net Runtime repository. Perhaps they already fixed the issues. If no we could suppress the warnings on file level:

[ExcepInfo.cs]
dotnet_diagnostic.IDE0044.severity = none

(For generated code https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/configuration-options#exclude-generated-code)

Doesn't this work?

Configure code analysis rules - .NET

Learn how to configure code analysis rules in an analyzer configuration file.

@xtqqczze Please look the code in .Net Runtime repository. Perhaps they already fixed the issues. If no we could suppress the warnings on file level:

[ExcepInfo.cs]
dotnet_diagnostic.IDE0044.severity = none

(For generated code https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/configuration-options#exclude-generated-code)

Doesn't this work?

@iSazonov Unless I specify the absolute path, I see warning InvalidGlobalSectionName, so probably this approach doesn't work in a GlobalConfig file. In any case, suppression in a GlobalSuppressions.cs file works for this PR. Ideally, the ComInterop code would be split to separate project and we set RunAnalyzers to false in the csproj. We could open an issue to discuss the best approach.

Depends on #15704.

@iSazonov Unless I specify the absolute path, I see warning InvalidGlobalSectionName, so probably this approach doesn't work in a GlobalConfig file. In any case, suppression in a GlobalSuppressions.cs file works for this PR. Ideally, the ComInterop code would be split to separate project and we set RunAnalyzers to false in the csproj. We could open an issue to discuss the best approach.

absolute path? What about relative?

I don't like the assembly level suppression and I'd consider it as only last resort.

I believe we don't want ComInterop in separate project because we don't want new additional dll.

@iSazonov Unless I specify the absolute path, I see warning InvalidGlobalSectionName, so probably this approach doesn't work in a GlobalConfig file. In any case, suppression in a GlobalSuppressions.cs file works for this PR. Ideally, the ComInterop code would be split to separate project and we set RunAnalyzers to false in the csproj. We could open an issue to discuss the best approach.

absolute path? What about relative?

I don't like the assembly level suppression and I'd consider it as only last resort.

It seems that section headers for global AnalyzerConfig files must specify an absolute file path. A relative file path produces a compiler warning and is ignored.

🎉v7.2.0-preview.8 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes