WebCmdlets parse XML declaration to get encoding value, if present.#18748
WebCmdlets parse XML declaration to get encoding value, if present.#18748iSazonov merged 10 commits intoPowerShell:masterfrom
Conversation
src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/StreamHelper.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/StreamHelper.cs
Show resolved
Hide resolved
src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/StreamHelper.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.PowerShell.Commands.Utility/commands/utility/WebCmdlet/StreamHelper.cs
Outdated
Show resolved
Hide resolved
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
🎉 Handy links: |
PR Summary
This PR adds a regex to get the charset from the XML declaration.
PR Context
After this PR I think we can close #3267, the current release already parses the HTML meta charset attribute.
Implements part of the logic proposed by @mklement0 in #11547
#11547 (comment)
Test:
InvokeWeb-Request "https://fossies.org/linux/www/mnogosearch-3.4.1.tar.gz/mnogosearch-3.4.1/msearch-test/test-parsexml/htdocs/cp1251.xml?m=t"(tested on a random windows-1251 xml I found online)