Fix share completion with provider and spaces#19440
Fix share completion with provider and spaces#19440iSazonov merged 9 commits intoPowerShell:masterfrom
Conversation
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Outdated
Show resolved
Hide resolved
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
src/System.Management.Automation/engine/CommandCompletion/CompletionCompleters.cs
Outdated
Show resolved
Hide resolved
|
This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days. |
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
|
The @PowerShell/wg-powershell-engine discussed this and believe this change to be proper from a behavioral perspective. |
So follow will do not work? Get-ChildItem -Path \\.\C:\<tab> |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
I guess creating the share requires admin rights. Do you have a preferred way for me to skip this test when not elevated, or should I just add the classic: to the skip parameter for the test? |
|
@MartinGC94 There are CIs with elevated rights. Please use: |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Request for new tests was resolved.
PR Summary
Stops the regex pattern for fileshares from (incorrectly) finding Windows device paths.
Makes the list item/tooltip text for fileshare completions consistent with normal path completion behavior.
Fixes tab completion for share names when specifying the filesystem provider like this:
Microsoft.PowerShell.Core\FileSystem::\\localhost\<Tab>previously you would get no results.Also fixes tab completion for file shares which are currently not quoted as they should when they contain spaces.
I have a question about adding a test share for this scenario. Can I just do it? Do I need to do anything special with the share ACL?
PR Context
Fixes #7569
Fixes #10002
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).