Fix #20400, Start-Process with -NoNewWindow returns null ExitCode on Process object with -PassThru by CodeCyclone · Pull Request #20749 · PowerShell/PowerShell

CodeCyclone · 2023-11-22T02:05:57Z

PR Summary

Fixing issue #20400 along with some duplicates.

This issue was introduced by change #19096.
This change moved from .NET creating process objects to use P/Invoke (Windows APIs). The code would fetch the Process object from .NET but by design it throws an exception silently and ExitCode is null because it didn't handle spawning the process itself.

Calling the Handle property on the fetched Process will resolve ExitCode state because it fetches the underlying SafeHandle used to update the ExitCode property.

PR Context

When you call Start-Process with -NoNewWindow, ExitCode will be null. This breaks a lot of customers of PowerShell both internally and externally.

PR Checklist

Fixing issue PowerShell#20400. This issue was introduced by change PowerShell#19096. This change moved from .NET creating process objects to use P/Invoke (Windows APIs). The code would fetch the Process object from .NET but by design it throws an exception silently and ExitCode is null because it didn't spawn the process. Calling Handle property on the fetched Process will resolve ExitCode state because it fetches the underlying SafeHandle used to update the ExitCode property.

iSazonov · 2023-11-22T05:30:28Z

@CodeCyclone Please add test(s) to avoid regressions.

src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs

SteveL-MSFT

Please add a test in https://github.com/PowerShell/PowerShell/blob/811efa46df822bf7be6179b6219f9f9d160eb7d5/test/powershell/Modules/Microsoft.PowerShell.Management/Start-Process.Tests.ps1

CodeCyclone · 2023-11-30T23:58:03Z

Added test, addressed feedback on commenting change. Added more detail and referenced issue.
Screenshot of the test failing without my fix:

SteveL-MSFT

LGTM

src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs

Removed referencing issue

src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs

…nt/Process.cs

pull-request-quantifier-deprecated · 2023-12-07T18:34:08Z

This PR has 4 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Small
Size       : +4 -0
Percentile : 1.6%

Total files changed: 2

Change summary by file extension:
.cs : +1 -0
.ps1 : +3 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

microsoft-github-policy-service · 2023-12-07T19:11:36Z

📣 Hey @CodeCyclone, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://forms.office.com/r/P926k48jRJ

Microsoft Forms

… accessible for the returned `Process` object (#20749)

… accessible for the returned `Process` object (#20749) (#20866)

… accessible for the returned `Process` object (PowerShell#20749)

CodeCyclone requested review from adityapatwardhan and daxian-dbw as code owners November 22, 2023 02:05

pull-request-quantifier-deprecated bot added the Extra Small label Nov 22, 2023

iSazonov requested a review from jborean93 November 22, 2023 05:27

iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Nov 22, 2023

jborean93 reviewed Nov 22, 2023

View reviewed changes

src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs Outdated Show resolved Hide resolved

SteveL-MSFT added the BackPort-7.4.x-Consider label Nov 27, 2023

SteveL-MSFT requested changes Nov 27, 2023

View reviewed changes

microsoft-github-policy-service bot added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 27, 2023

Improved comment, addressing PR feedback

0889eee

microsoft-github-policy-service bot removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Nov 30, 2023

Added test

f954cf0

SteveL-MSFT approved these changes Dec 1, 2023

View reviewed changes

SteveL-MSFT assigned TravisEz13 Dec 1, 2023

iSazonov reviewed Dec 1, 2023

View reviewed changes

src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs Outdated Show resolved Hide resolved

Update Process.cs

d5b1928

Removed referencing issue

SteveL-MSFT added the CommunityDay-Small A small PR that the PS team has identified to prioritize to review label Dec 6, 2023

SteveL-MSFT assigned daxian-dbw and unassigned TravisEz13 Dec 7, 2023

daxian-dbw approved these changes Dec 7, 2023

View reviewed changes

src/Microsoft.PowerShell.Commands.Management/commands/management/Process.cs Outdated Show resolved Hide resolved

Update src/Microsoft.PowerShell.Commands.Management/commands/manageme…

416c564

…nt/Process.cs

daxian-dbw enabled auto-merge (squash) December 7, 2023 18:39

daxian-dbw merged commit 3eda139 into PowerShell:master Dec 7, 2023

SteveL-MSFT added BackPort-7.4.x-Approved and removed BackPort-7.4.x-Consider labels Dec 7, 2023

daxian-dbw pushed a commit that referenced this pull request Dec 7, 2023

Fix Start-Process -PassThru to make sure the ExitCode property is…

38cf1ea

… accessible for the returned `Process` object (#20749)

daxian-dbw mentioned this pull request Dec 7, 2023

[release/v7.4.1] Fix #20400, Start-Process with -NoNewWindow returns null ExitCode on Process object with -PassThru #20866

Merged

daxian-dbw added a commit that referenced this pull request Dec 8, 2023

Fix Start-Process -PassThru to make sure the ExitCode property is…

851d21b

… accessible for the returned `Process` object (#20749) (#20866)

daxian-dbw added BackPort-7.4.x-Done and removed BackPort-7.4.x-Approved labels Dec 13, 2023

bartvermeersch mentioned this pull request Jan 20, 2024

PS v7.4.1 breaks passing credentials to start-process #21073

Closed

5 tasks

jborean93 mentioned this pull request Mar 30, 2024

Start-Process: Fix -Credential error as non-admin #21393

Merged

22 tasks

chrisdent-de pushed a commit to chrisdent-de/PowerShell that referenced this pull request Sep 12, 2024

Fix Start-Process -PassThru to make sure the ExitCode property is…

91f94ec

… accessible for the returned `Process` object (PowerShell#20749)

jshigetomi mentioned this pull request Jan 21, 2025

Fix backport issues with release pipeline #24835

Merged

21 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #20400, Start-Process with -NoNewWindow returns null ExitCode on Process object with -PassThru#20749

Fix #20400, Start-Process with -NoNewWindow returns null ExitCode on Process object with -PassThru#20749
daxian-dbw merged 5 commits intoPowerShell:masterfrom
CodeCyclone:dev/cc/startProcessNullExitCode

CodeCyclone commented Nov 22, 2023 •

edited

Loading

Uh oh!

iSazonov commented Nov 22, 2023

Uh oh!

Uh oh!

SteveL-MSFT left a comment

Uh oh!

CodeCyclone commented Nov 30, 2023

Uh oh!

SteveL-MSFT left a comment

Uh oh!

Uh oh!

Uh oh!

pull-request-quantifier-deprecated bot commented Dec 7, 2023

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

microsoft-github-policy-service bot commented Dec 7, 2023 •

edited by unfurl-links bot

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

CodeCyclone commented Nov 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

iSazonov commented Nov 22, 2023

Uh oh!

Uh oh!

SteveL-MSFT left a comment

Choose a reason for hiding this comment

Uh oh!

CodeCyclone commented Nov 30, 2023

Uh oh!

SteveL-MSFT left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pull-request-quantifier-deprecated bot commented Dec 7, 2023

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

microsoft-github-policy-service bot commented Dec 7, 2023 • edited by unfurl-links bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

CodeCyclone commented Nov 22, 2023 •

edited

Loading

microsoft-github-policy-service bot commented Dec 7, 2023 •

edited by unfurl-links bot

Loading