Skip to content

Comments

[2.10] Use new info API of VecSim for metrics [MOD-9354]#5938

Merged
GuyAv46 merged 3 commits into2.10from
backport-5911-to-2.10
Apr 15, 2025
Merged

[2.10] Use new info API of VecSim for metrics [MOD-9354]#5938
GuyAv46 merged 3 commits into2.10from
backport-5911-to-2.10

Conversation

@GuyAv46
Copy link
Collaborator

@GuyAv46 GuyAv46 commented Apr 15, 2025

Description

Backport of #5911 to 2.10.
Also reverts #5893

alonre24 and others added 2 commits April 15, 2025 12:33
* Use new info API of vecsim

* change to fixed main

* attempt to fix a test

* fix

* another attempt

* another attempt

* fix type and add info to test_hybrid_query_with_geo

* another attempt

* finalize test fix

* update vecsim tag

---------

Co-authored-by: GuyAv46 <guy.avimor@gmail.com>
(cherry picked from commit 383ed64)
@GuyAv46 GuyAv46 requested a review from lerman25 April 15, 2025 10:50
@GuyAv46 GuyAv46 enabled auto-merge April 15, 2025 10:51
@GuyAv46 GuyAv46 disabled auto-merge April 15, 2025 10:51
@GuyAv46 GuyAv46 enabled auto-merge April 15, 2025 10:54
@codecov
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.67%. Comparing base (3c9acf8) to head (5db7e97).
Report is 2 commits behind head on 2.10.

Files with missing lines Patch % Lines
src/spec.c 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             2.10    #5938      +/-   ##
==========================================
+ Coverage   86.64%   86.67%   +0.02%     
==========================================
  Files         201      201              
  Lines       34444    34443       -1     
==========================================
+ Hits        29844    29853       +9     
+ Misses       4600     4590      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GuyAv46 GuyAv46 added this pull request to the merge queue Apr 15, 2025
Merged via the queue into 2.10 with commit d8a5a50 Apr 15, 2025
8 of 9 checks passed
@GuyAv46 GuyAv46 deleted the backport-5911-to-2.10 branch April 15, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants