Merged
Conversation
Collaborator
|
Did the tests fail in questa on master as well? Unfortunately we cannot run CI on the commercial simulators like we do with GHDL. |
Contributor
Author
|
The test already there, yes. It is the "tb_avalon_master.wait until idle" test in probably all configurations. I did not look into it - it fails with questa but is ok with ghdl. Then the new testcase "tb_axi_stream.test back-to-back failing check" fails with questa, but not with ghdl. This is related to the setting-up of the logging mock. I played around a bit with the order of the delays and commands. It seems I can make it work with questa easily, but then it fails with ghdl. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #477
I reused the same function with an additional argument with default value for backward compatibility (compared to the current master).
I prefer that to a separate function, but let me know if you think otherwise.
Only the specific axi_stream stuff is updated. One could think of doing the same to the generic stream_slave, but I can't handle the consequences (would need to update the uart...).
Running all checks in verification_components seems to fail with questa due to some delta-cycle differences with GHDL... :-/ GHDL looks fine here.