Merged
Conversation
Collaborator
|
I am basically ok with this as it makes the structure better. Regarding test vs tests I think tests should really be outside the vunit folder. Moving it outside also makes it less confusing. |
added 5 commits
November 12, 2019 21:59
Collaborator
Author
Good idea! It is done now. BTW, |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the same approach as with
ui.py, in this PR:vunit.sim_ifsubmodule is created.testis renamed totests.testis created, and all thevunit/test_*.pysources are moved there.vunit.ui.vunitis merged intovunit/ui/__init__.pyand unused imports are removed.