Move VHPIDIRECT related sources (implementation and example) to separate repo#606
Merged
eine merged 7 commits intoVUnit:masterfrom Feb 20, 2020
Merged
Move VHPIDIRECT related sources (implementation and example) to separate repo#606eine merged 7 commits intoVUnit:masterfrom
eine merged 7 commits intoVUnit:masterfrom
Conversation
1a39ee4 to
de76a54
Compare
783592b to
327a153
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As commented in #603 (comment), this is a draft to remove VHDL and C sources related to VHPIDIRECT from this repository. The prosopal is as follows:
vunit/vhdl/data_types/src/externaltovunit/vhdl/data_types/src/api:ghdl.external_*-vhpi.vhd.external_*-novhpi.vhdandexternal_*-body.vhd; rename toexternal_*_pkg_.vhd.examples/vhdl/external_buffer(remove it fromtests/acceptance/test_external_run_scripts.pytoo).builtins._add_data_typesis simplified accordingly:{'string': ['path/to/custom/file'], 'integer': ['path/to/custom/file']}is supported. The defaultvunit/vhdl/data_types/src/api/external_*_pkg_.vhdis used when: any of the fields does not exist, isFalse, or isNone. Otherwise, the user-provided file is used.builtins._add_filesis enhanced in order to check if provided files actually exist.All the content that has been removed (the example,
*-vhpi.vhdsources and subdirghdl) is expected to be added to a newvunit/cosimrepository. In fact, this draft PR is a result of the discussion that is going on in #603.Note that this does not revert the 'external modes' feature introduced in
v4.3.0. Files invunit/vhdl/data_types/*.vhdare not modified at all. Hence, this is just a reorganization of the sources that moves specific implementations (e.g. GHDL's VHPIDIRECT) to a separate repository.