codec: fix "prefix of array attribute must be an object name"#635
Merged
eine merged 3 commits intoVUnit:masterfrom Mar 26, 2020
Merged
codec: fix "prefix of array attribute must be an object name"#635eine merged 3 commits intoVUnit:masterfrom
eine merged 3 commits intoVUnit:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A change in v0.37 made some of the tests in VUnit fail. #631 fixed some of them, but four are still failing:
According to ghdl/ghdl#1152, this is something that needs to be fixed in VUnit's codebase.
In this PR, helper functions
get_encoded_length,get_decoded_range_rightandget_decoded_range_leftare added. These replace existing helper varsrange_leftandrange_rightthat were used for RivieraPRO.To do: