Conversation
tannewt
approved these changes
Oct 6, 2025
Member
tannewt
left a comment
There was a problem hiding this comment.
I suspect you need it for the iterator too since you are accessing the i_get field in the struct. Otherwise the struct may be of an objinstance IIRC.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do proper native object casting to allow subclassing
deqeue. Added a test which works, and would cause crashes before the changes here.@tannewt It is not clear to me whether the casting in the iteration routines is necessary now, but I think it would be if they were made explicit.