Skip to content

Comments

Remove path to string convertion#1612

Merged
JrooTJunior merged 2 commits intodev-3.xfrom
chore/rm-path-to-string
Jan 4, 2025
Merged

Remove path to string convertion#1612
JrooTJunior merged 2 commits intodev-3.xfrom
chore/rm-path-to-string

Conversation

@Olegt0rr
Copy link
Contributor

@Olegt0rr Olegt0rr commented Dec 1, 2024 •
edited
Loading

Description

Fixes #1611

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples or any documentation update)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Other

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actions github-actions bot added the 3.x Issue or PR for stable 3.x version label Dec 1, 2024
@github-actions
Copy link

github-actions bot commented Dec 1, 2024 •
edited
Loading

✔️ Changelog found.

Thank you for adding a description of the changes

@Olegt0rr Olegt0rr self-assigned this Dec 1, 2024
@Olegt0rr Olegt0rr added the skip news Pull request can be merged without describing changes label Dec 1, 2024
@codecov
Copy link

codecov bot commented Dec 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6520b9f) to head (4eee997).
Report is 9 commits behind head on dev-3.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           dev-3.x     #1612      +/-   ##
============================================
+ Coverage    99.63%   100.00%   +0.36%     
============================================
  Files          478       484       +6     
  Lines        12116     12205      +89     
============================================
+ Hits         12072     12205     +133     
+ Misses          44         0      -44
Flag Coverage Δ
unittests 100.00% <100.00%> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
aiogram/client/bot.py 100.00% <100.00%> (ø)
aiogram/client/telegram.py 100.00% <100.00%> (ø)

... and 15 files with indirect coverage changes

@Olegt0rr Olegt0rr requested a review from a team December 1, 2024 23:29
@Olegt0rr Olegt0rr assigned JrooTJunior and unassigned Olegt0rr Dec 2, 2024
@Olegt0rr Olegt0rr assigned Olegt0rr and unassigned JrooTJunior Dec 15, 2024
@Olegt0rr Olegt0rr removed the skip news Pull request can be merged without describing changes label Dec 15, 2024
@Olegt0rr Olegt0rr requested a review from JrooTJunior January 2, 2025 23:04
@Olegt0rr Olegt0rr changed the title Remove path to string conversion Remove path to string convertion Jan 2, 2025
@JrooTJunior JrooTJunior merged commit 44bd8fe into dev-3.x Jan 4, 2025
23 checks passed
@Olegt0rr Olegt0rr deleted the chore/rm-path-to-string branch January 4, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JrooTJunior JrooTJunior JrooTJunior approved these changes

Assignees

@JrooTJunior JrooTJunior

@Olegt0rr Olegt0rr

Labels

3.x Issue or PR for stable 3.x version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unnecessary path to string conversion

2 participants

@Olegt0rr @JrooTJunior