Created GlobalForward and Forward methodmaps#1004
Created GlobalForward and Forward methodmaps#1004Headline merged 10 commits intoalliedmodders:masterfrom JoinedSenses:patch-4
Conversation
|
Another thought I have regarding this is to add all |
plugins/include/functions.inc
Outdated
| } | ||
| }; | ||
|
|
||
| methodmap Forward < GlobalForward { |
There was a problem hiding this comment.
How do you feel about PrivateForward? That is what we call it in the doc comment and it feels more balanced against GlobalForward (which is generally the one people are using anyway). That said, calling them "private" and "global" forwards has never really made sense and this is a good opportunity to change the terminology, some nomenclature around "managed" might be clearer?
There was a problem hiding this comment.
It makes sense to have PrivateForward instead of just Forward. If not "private" and "global", you're suggesting "managed" and "unmanaged"? Something about these terms don't sit right with me, perhaps because it's terminology i've already come to terms with. That and "private"/"global" are referenced in a ton of places already, so it might be weird going back on that.
There was a problem hiding this comment.
Ill fix tonight, uncaught change when reverting whitespace commit
There was a problem hiding this comment.
This oversight has been addressed in the latest commit. 26eb127
plugins/include/functions.inc
Outdated
| } | ||
| }; | ||
|
|
||
| methodmap Forward < GlobalForward { |
This was an oversight on my end due to trying to revert changes.
This PR introduces types GlobalForward and Forward by creating methodmaps for the two. Pretty straight forward. As usual, please let me know if something looks off or could use improvement.