Throw configuration error on unsupported compilers#1029
Merged
Conversation
rather than having less obvious errors thrown later by compiler.
Headline
approved these changes
Nov 13, 2019
Member
Headline
left a comment
There was a problem hiding this comment.
This should be complete, gonna merge this soon if no one has any complaints about it.
GCC and Clang requirements were taken from amtl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throw error at configure stage if using unsupported MSVC version rather than having less obvious errors thrown later by compiler.
With the recent argbuffer addition, we apparently no longer support Visual Studio 2013. I removed a couple of paths for it, and added an early check to make sure a supported version is being used. I think we should do the same for GCC and Clang as well, but I don't know what minimum versions we support.