Update TF2_IgnitePlayer to support set duration of fire#1038
Merged
asherkin merged 3 commits intoalliedmodders:masterfrom Jul 5, 2019
Merged
Update TF2_IgnitePlayer to support set duration of fire#1038asherkin merged 3 commits intoalliedmodders:masterfrom
asherkin merged 3 commits intoalliedmodders:masterfrom
Conversation
asherkin
requested changes
Jul 5, 2019
|
|
Member
|
It won't break compilation of existing code since the new parameter is being added with a default value. Plugins that don't have the new argument specified will implicitly use the default. |
|
My bad, definitely didn't see the default value. |
Contributor
Author
|
oops new to those stuff, hopefully i did this correctly |
psychonic
approved these changes
Jul 5, 2019
asherkin
approved these changes
Jul 5, 2019
Member
|
Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #713
This PR adds 3rd param
TF2_IgnitePlayerto allow set duration of fire, while default value kept as 10.0 so older plugins should not break.However when i tested this, i found out fire duration is capped to 10.0 seconds, even when tempted to set higher than 10. I believe this is valve's shitty fix on infinite fire duration from some weapons, which is really unfortunate. May still be helpful to some plugins when setting fire less than 10 seconds.
Example code when testing this, setting yourself on fire with duration.