Fix edge case basecommands plugin error#1138
Merged
Headline merged 1 commit intoalliedmodders:masterfrom Feb 7, 2020
Merged
Conversation
Headline
approved these changes
Feb 7, 2020
Member
Headline
left a comment
There was a problem hiding this comment.
Ha, this is an interesting one. Thanks, sneak-y boy!
asherkin
pushed a commit
that referenced
this pull request
Feb 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing a plugin I was creating, I needed to use
sm_rconto kick myself from the server console to ensure my console check was working as intended.I found that when using
sm_rcon kick me, I got this error:So as the title states, this is an extreme edge case and does not apply when using
sm_rcon sm_kick, but I figure a proper IsClientConnected check was in order to not throw an error in an odd case like this.I also took the liberty of formatting the couple lines leading up to the fix to match the coding style of the rest of the plugin, hope that's okay.