Fix "Command Group" override type admin flags#1349
Merged
asherkin merged 1 commit intoalliedmodders:masterfrom Sep 7, 2020
Sikarii:fix-cmd-group-update-flags
Merged
Fix "Command Group" override type admin flags#1349asherkin merged 1 commit intoalliedmodders:masterfrom Sikarii:fix-cmd-group-update-flags
asherkin merged 1 commit intoalliedmodders:masterfrom
Sikarii:fix-cmd-group-update-flags
Conversation
asherkin
approved these changes
Sep 4, 2020
Member
asherkin
left a comment
There was a problem hiding this comment.
Thanks for the fix - I love how this one survived the ages.
It must be almost 10 years since I also tried to setup command group overrides and just went "well that doesn't work" - so great job digging into it and fixing them!
Contributor
|
I have tried to test "Command group" one whole day for nothing :D dam bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes "Command Group" override type getting set wrong flags upon the creation of the command group override.
One way to test this broken behaviour is to:
MyTestGroup.RegAdminCmd("sm_testcommand", Command_Test, ADMFLAG_ROOT, "Description", "MyTestGroup");admin_overrides.cfg-"@MyTestGroup" "".