Add new trie native: ContainsKey()#1390
Merged
Headline merged 3 commits intoalliedmodders:masterfrom Dec 1, 2020
einyux:feature-trie
Merged
Add new trie native: ContainsKey()#1390Headline merged 3 commits intoalliedmodders:masterfrom einyux:feature-trie
Headline merged 3 commits intoalliedmodders:masterfrom
einyux:feature-trie
Conversation
Headline
requested changes
Nov 29, 2020
Headline
approved these changes
Nov 30, 2020
asherkin
approved these changes
Nov 30, 2020
Member
asherkin
left a comment
There was a problem hiding this comment.
LGTM, thanks - could bikeshed the name forever but I think ContainsKey is nice and clear.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing fancy here, just a new native to check if a key exists in a trie.
It helps to avoid to create a dummy variable when using GetTrieXXX() to check a key existence.
Native name can be changed if it's not to your liking :-D.