core: Fix not working MENU_DEBUG#1506
Merged
asherkin merged 3 commits intoalliedmodders:masterfrom Jun 21, 2021
Merged
Conversation
dvander
approved these changes
Jun 21, 2021
asherkin
requested changes
Jun 21, 2021
Member
asherkin
left a comment
There was a problem hiding this comment.
This doesn't look right, you can't use an internal header from logic inside core - the extern won't be populated at runtime as it is part of the logic binary instead.
The code needs updating to use the logger global provided by logic_bridge.h (already included here), which'll call over into the correct library.
Contributor
Author
|
Works |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a compilation error