Fix TF2_OnIsHolidayActive forward not getting called after map change#1752
Merged
peace-maker merged 2 commits intoalliedmodders:masterfrom Apr 22, 2022
Merged
Fix TF2_OnIsHolidayActive forward not getting called after map change#1752peace-maker merged 2 commits intoalliedmodders:masterfrom
peace-maker merged 2 commits intoalliedmodders:masterfrom
Conversation
Member
|
Maybe it's better to just call the function |
Contributor
Author
I agree. Done. |
peace-maker
approved these changes
Apr 20, 2022
asherkin
pushed a commit
that referenced
this pull request
May 4, 2022
…#1752) * Fix TF2_IsHolidayActive forward not getting called after map change * Rename function to Unhook
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1747
After a map change, the virtual hook on
IsHolidayActivewill be invalid due to the gamerules object being destroyed, but current code does not attempt to hook it again if a plugin using theTF2_OnIsHolidayActiveforward is still loaded.Always unhook on level change, and check for plugins using the forward only in
HolidayManager::OnPluginUnloaded.