Improve HasEntProp performance#1908
Merged
Headline merged 1 commit intoalliedmodders:masterfrom Mar 30, 2023
Merged
Conversation
Contributor
Author
|
I left the first command in the testing code because it was used to verify that HasEntProp was also returning the right values, which it seems to. |
Member
|
Nice work, thanks for this! I'll try and take a look in the next few days - prod me on Discord if I forget. |
Member
|
Can a method be exposed for extensions to purge the cache ? |
Headline
approved these changes
Mar 3, 2023
Member
Headline
left a comment
There was a problem hiding this comment.
If we want to do cache invalidation later, I'm cool with this now. I'm afraid this will overcook
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the
HasEntPropoptimization suggested by asherkin in the discord (caching missed lookups).I tried to make any changes as non-disruptive as possible because I barely know what I'm doing, so it could probably be optimized further.
Testing shows it to be roughly 2-3x faster:
Using the following code, specifically
sm_hasentprop2(which is probably not a good test):The props used are either common, less common, or invalid for each of Prop_Send and Prop_Data.