Skip to content

fix(tty_roles.py): handle role assignment errors#864

Merged
anemoijereja-eden merged 1 commit intomainfrom
tty-fix
May 13, 2025
Merged

fix(tty_roles.py): handle role assignment errors#864
anemoijereja-eden merged 1 commit intomainfrom
tty-fix

Conversation

@electron271
Copy link
Member

@electron271 electron271 commented May 13, 2025 •
edited by sourcery-ai bot
Loading

fixes issue if user is kicked/leaves within 5 seconds

Summary by Sourcery

Bug Fixes:

  • Catch discord.NotFound during delayed role assignment to detect if the member left or was kicked and log an info message instead of an error.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented May 13, 2025 •
edited
Loading

Reviewer's Guide

This PR enhances the role assignment logic by catching and handling discord.NotFound errors—specifically to detect if a member has left or been kicked before a delayed role assignment—and logs accordingly to avoid silent failures.

File-Level Changes

Change Details Files
Add explicit handling for NotFound errors during delayed role assignment
  • Wrap member.add_roles in except discord.NotFound
  • Verify member still exists in guild before retry
  • Log info if member left/kicked; log error otherwise
 tux/cogs/services/tty_roles.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@electron271 electron271 self-assigned this May 13, 2025
sourcery-ai[bot]
sourcery-ai bot reviewed May 13, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @electron271 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

tux/cogs/services/tty_roles.py
if member.guild.get_member(member.id) is None:
logger.info(f"Member {member} left or got kicked by the server before the role could be assigned.")
return
logger.error(f"Failed to assign role {role.name} to {member}: {error}")
Copy link
Contributor

@sourcery-ai sourcery-ai bot May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider lowering log level for expected NotFound errors

If a missing member is truly unexpected, keep the error level; otherwise (e.g. role deletion or race condition), switch to warning or debug to reduce log noise.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented May 13, 2025

Deploying tux with  Cloudflare Pages  Cloudflare Pages

Latest commit: ca39dc6
Status: ✅  Deploy successful!
Preview URL: https://b6a1e195.tux-afh.pages.dev
Branch Preview URL: https://tty-fix.tux-afh.pages.dev

View logs

@anemoijereja-eden anemoijereja-eden merged commit b0fb7e1 into main May 13, 2025
10 checks passed
@anemoijereja-eden anemoijereja-eden deleted the tty-fix branch May 13, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@anemoijereja-eden anemoijereja-eden anemoijereja-eden approved these changes

Assignees

@electron271 electron271

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@electron271 @anemoijereja-eden