This repository was archived by the owner on Feb 26, 2023. It is now read-only.
do not call setIntent() in onNewIntent()#1607
Merged
WonderCsabo merged 1 commit intoandroidannotations:developfrom Oct 29, 2015
dodgex:1578_do_not_override_onNewIntent
Merged
do not call setIntent() in onNewIntent()#1607WonderCsabo merged 1 commit intoandroidannotations:developfrom dodgex:1578_do_not_override_onNewIntent
WonderCsabo merged 1 commit intoandroidannotations:developfrom
dodgex:1578_do_not_override_onNewIntent
Conversation
Member
|
Hmm, we did not have tests for this? BTW, you are fast. |
Member
Author
|
does not seem to be tested. there where no failures |
Member
Author
|
I'm the Flash! =) |
WonderCsabo
added a commit
that referenced
this pull request
Oct 29, 2015
Do not call setIntent() in onNewIntent()
Member
|
@dodgex can you update the wiki and add a warning about this breaking change? |
Member
Author
|
hmmm looks like we never mentioned that we override onNewIntent. do you know with which version we introduced the override? |
Member
|
AA 3.2. |
Member
Author
Member
Author
|
Thank you for the info. :) |
Member
|
Wiki merged, thx.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #1578