Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Added newline at eof checkstyle rule.#1560

Merged
WonderCsabo merged 1 commit intoandroidannotations:developfrom
johncarl81:newline
Sep 19, 2015
Merged

Added newline at eof checkstyle rule.#1560
WonderCsabo merged 1 commit intoandroidannotations:developfrom
johncarl81:newline

Conversation

@johncarl81
Copy link
Contributor

@johncarl81 johncarl81 commented Sep 19, 2015

No description provided.

@johncarl81 johncarl81 mentioned this pull request Sep 19, 2015
Merged
@dodgex
Copy link
Member

dodgex commented Sep 19, 2015

nice one 👍

@johncarl81
Copy link
Contributor Author

johncarl81 commented Sep 19, 2015

Not sure why Travis is unhappy.. any ideas?

@dodgex
Copy link
Member

dodgex commented Sep 19, 2015 

[ERROR] src/test/java/org/androidannotations/rest/spring/ClientWithWrongEnhancedMethod.java[0] (misc) NewlineAtEndOfFile: File does not end with a newline.
[ERROR] src/test/java/org/androidannotations/rest/spring/WrongConstructorInterceptor.java[0] (misc) NewlineAtEndOfFile: File does not end with a newline.
[ERROR] src/test/java/org/androidannotations/rest/spring/WrongConstructorResponseErrorHandler.java[0] (misc) NewlineAtEndOfFile: File does not end with a newline.

@WonderCsabo
Copy link
Member

WonderCsabo commented Sep 19, 2015

Thanks for this PR! Can you correct the three files listed in #1560 (comment) ?

@johncarl81 johncarl81 force-pushed the newline branch 3 times, most recently from 2248d43 to af3b66b Compare September 19, 2015 15:33
WonderCsabo added a commit that referenced this pull request Sep 19, 2015
@WonderCsabo
Merge pull request #1560 from johncarl81/newline
71b66b4 
Add newline at eof Checkstyle rule
@WonderCsabo WonderCsabo merged commit 71b66b4 into androidannotations:develop Sep 19, 2015
@WonderCsabo WonderCsabo added this to the 4.0 milestone Sep 19, 2015
@johncarl81 johncarl81 deleted the newline branch September 20, 2015 04:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@johncarl81 @dodgex @WonderCsabo