This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Remove @Path's placeholder#1631
Merged
WonderCsabo merged 2 commits intoandroidannotations:developfrom Nov 19, 2015
shiraji:1602_remove_path_placeholder
Merged
Remove @Path's placeholder#1631WonderCsabo merged 2 commits intoandroidannotations:developfrom shiraji:1602_remove_path_placeholder
@Path's placeholder#1631WonderCsabo merged 2 commits intoandroidannotations:developfrom
shiraji:1602_remove_path_placeholder
Conversation
Member
There was a problem hiding this comment.
Maybe we could more specific here? (The user must add @Path here, not?)
Member
There was a problem hiding this comment.
Or there are missing url variables corresponding to the @RequiresCookieInUrl annotation.
Contributor
Author
|
Fixed it. |
Contributor
Author
|
Wiki is updated, too. |
Member
|
Can you squash the commits (so only two commits remain). |
Contributor
Author
|
Squashed. |
WonderCsabo
added a commit
that referenced
this pull request
Nov 19, 2015
Require @path for url variables
Member
|
Thanks, great work. I also merged the wiki. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #1602 and #1615
#1615 only implementing
@Bodynot replacting@Pathplaceholder function.