Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Added @IgnoreWhen#1664

Merged
WonderCsabo merged 4 commits intoandroidannotations:developfrom
shiraji:1597_add_ignore_when
Dec 20, 2015
Merged

Added @IgnoreWhen#1664
WonderCsabo merged 4 commits intoandroidannotations:developfrom
shiraji:1597_add_ignore_when

Conversation

@shiraji
Copy link
Contributor

@shiraji shiraji commented Dec 19, 2015

see #1597

@shiraji shiraji force-pushed the 1597_add_ignore_when branch from dbd8edf to 2c5ac88 Compare December 19, 2015 00:51
WonderCsabo
WonderCsabo reviewed Dec 19, 2015
View reviewed changes
...core/androidannotations-api/src/main/java/org/androidannotations/annotations/IgnoreWhen.java Outdated
Copy link
Member

@WonderCsabo WonderCsabo Dec 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would write: the lifecycle state after the method should not be executed

Copy link
Member

@WonderCsabo WonderCsabo Dec 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please use sentences, the first word is capitalized etc.

@WonderCsabo
Copy link
Member

WonderCsabo commented Dec 19, 2015

Thanks for this PR! Looks good in general, please address my comments.

@WonderCsabo
Copy link
Member

WonderCsabo commented Dec 19, 2015

A side note: can you use imperative, present tense (Rename IgnoredWhenDetached to IgnoreWhen) for commit messages?

@shiraji shiraji force-pushed the 1597_add_ignore_when branch from 2c5ac88 to efe1345 Compare December 19, 2015 12:12
@shiraji
Copy link
Contributor Author

shiraji commented Dec 19, 2015

Didn't know that...thank for letting know that. I will use present tense from this pull request!

@shiraji
Copy link
Contributor Author

shiraji commented Dec 19, 2015

There you go.

WonderCsabo
WonderCsabo reviewed Dec 19, 2015
View reviewed changes
...annotations-test/src/test/java/org/androidannotations/test/efragment/MyListFragmentTest.java Outdated
Copy link
Member

@WonderCsabo WonderCsabo Dec 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could just pass null to every parameter here, there is no need for mocking in this case.

@WonderCsabo
Copy link
Member

WonderCsabo commented Dec 19, 2015

I have just one comment. Please fix then squash.

@shiraji
Copy link
Contributor Author

shiraji commented Dec 19, 2015

Sure. I will make them all null and squash commits.

@shiraji shiraji force-pushed the 1597_add_ignore_when branch 2 times, most recently from 388aafa to 27f0c3f Compare December 19, 2015 14:42
@shiraji shiraji force-pushed the 1597_add_ignore_when branch from 27f0c3f to f22dfbd Compare December 20, 2015 00:36
@shiraji
Copy link
Contributor Author

shiraji commented Dec 20, 2015

Updated it shiraji@f22dfbd#diff-5474a5decd9ffab9908ae97c83444b47R143

WonderCsabo added a commit that referenced this pull request Dec 20, 2015
@WonderCsabo
Merge pull request #1664 from shiraji/1597_add_ignore_when
75c1446 
Added @IgnoreWhen
@WonderCsabo WonderCsabo merged commit 75c1446 into androidannotations:develop Dec 20, 2015
@WonderCsabo
Copy link
Member

WonderCsabo commented Dec 20, 2015

Thanks. Can you update the wiki as well?

@WonderCsabo WonderCsabo added this to the 4.0 milestone Dec 20, 2015
@shiraji shiraji deleted the 1597_add_ignore_when branch December 20, 2015 10:17
@shiraji
Copy link
Contributor Author

shiraji commented Dec 20, 2015

Sure!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@shiraji @WonderCsabo @dodgex